Skip to content

Cache remember#4107

Merged
paulbalandan merged 6 commits intocodeigniter4:developfrom
agungsugiarto:cache-remember
Jan 28, 2021
Merged

Cache remember#4107
paulbalandan merged 6 commits intocodeigniter4:developfrom
agungsugiarto:cache-remember

Conversation

@agungsugiarto
Copy link
Contributor

@agungsugiarto agungsugiarto commented Jan 15, 2021

Description
Retrieve & Store cache
Sometimes we wish to retrieve an item from the cache, but also store a default value if the requested item doesn't exist.
Usage:

$value = Service::cache->remember('sample', 3600, function () {
    return [
       'sample' => 'data',
    ];
});

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

paulbalandan
paulbalandan reviewed Jan 15, 2021
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be discussed in the user guide.

MGatner
MGatner requested changes Jan 15, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please participate in and resolve conversations.

paulbalandan
paulbalandan reviewed Jan 16, 2021
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a discussion in the user guide.

@paulbalandan
Copy link
Member

paulbalandan commented Jan 28, 2021

bump @agungsugiarto for the UG update

@agungsugiarto
Copy link
Contributor Author

agungsugiarto commented Jan 28, 2021

Forgive me @paulbalandan, im not good to write some documentation.

@paulbalandan
Copy link
Member

paulbalandan commented Jan 28, 2021

ping @samsonasik , there seems to be a problem with rector. It says it cannot find the ReflectionUnionType class. I think it's internally used by rector.

@samsonasik
Copy link
Member

samsonasik commented Jan 28, 2021 •
edited
Loading

@paulbalandan Yes, I reverted phpstan update #4173 . That issue happen after update to latest phpstan release 0.12.70.

@paulbalandan paulbalandan merged commit 7a0b54d into codeigniter4:develop Jan 28, 2021
@totoprayogo1916 totoprayogo1916 mentioned this pull request Jan 28, 2021
Merged
5 tasks
@paulbalandan paulbalandan removed the request for review from MGatner July 7, 2021 16:42
@datamweb datamweb mentioned this pull request Jan 8, 2026
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@MGatner MGatner MGatner requested changes

+1 more reviewer

@datamweb datamweb datamweb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@agungsugiarto @paulbalandan @samsonasik @datamweb @MGatner