feat: share connection & DNS Cache to CURLRequest#9557
feat: share connection & DNS Cache to CURLRequest#9557michalsn merged 9 commits intocodeigniter4:4.7from
CURLRequest#9557Conversation
|
This is a nice improvement, but I think it would benefit from being more configurable. How about introducing a We should also note in the user guide that the It's a bit unfortunate that we already have |
|
In new function persistent that avoid cookie, we avoid too? |
|
Do you mean |
8d5fe45 to
3c20b47
Compare
<?php
$optShareConnection = [
CURL_LOCK_DATA_CONNECT,
CURL_LOCK_DATA_DNS,
];
$this->shareConnection = curl_share_init();
foreach (array_unique($optShareConnection) as $opt) {
curl_share_setopt($this->shareConnection, CURLSHOPT_SHARE, $opt);
}same as persistent implementation in next PR (when ready): <?php
$optShareConnection = [
CURL_LOCK_DATA_CONNECT,
CURL_LOCK_DATA_DNS,
];
$this->shareConnection = curl_share_init_persistent($optShareConnection); |
CURLRequestCURLRequest
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
80cca03 to
251d092
Compare
|
Thank you @ddevsr |
Description
I need this for reuse connection. As soon PHP 8.5 will have new function for persistent, Benefit choosing persistent_id by PHP (read more on RFC).
php/php-src@d20880c#diff-6db2da0f77fa4c56808260fdf566a723bbb52d6159077953097d05d995335558R135-R245
https://wiki.php.net/rfc/curl_share_persistence_improvement
Checklist: