feat: update CookieInterface::EXPIRES_FORMAT to use date format per RFC 7231#9563
Merged
paulbalandan merged 3 commits intocodeigniter4:4.7from May 19, 2025
Merged
Conversation
michalsn
approved these changes
May 17, 2025
ddevsr
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When I first made this Cookie component, the MDN states that the date format is
D, d-M-Y H:i:s T(RFC 850). Now, it seems this format is obsolete and recommends using RFC 5322 format (D, d M Y H:i:s \G\M\T- without dashes`). This PR updates the date format to that.This change will not be breaking as per RFC 7231 section 7.1.1.1. Although RFC 850 is obsolete, it SHOULD still be accepted. Since we're moving from obsolete to recommended, I think we should not have any problems.
Checklist: