chore: add support for peer updates to tailnet.configMaps#11487
Merged
spikecurtis merged 1 commit intomainfrom Jan 11, 2024
Merged
chore: add support for peer updates to tailnet.configMaps#11487spikecurtis merged 1 commit intomainfrom
spikecurtis merged 1 commit intomainfrom
Conversation
This was referenced Jan 8, 2024
Contributor
Author
032d52d to
b03a760
Compare
d744013 to
76ec6f7
Compare
b03a760 to
6f37b9b
Compare
76ec6f7 to
2baf90f
Compare
2baf90f to
3844f8a
Compare
6f37b9b to
0ec3722
Compare
3844f8a to
e01bbcf
Compare
d013264 to
018e3b8
Compare
e01bbcf to
a02de8b
Compare
40c72c2 to
3b8d264
Compare
coadler
approved these changes
Jan 11, 2024
| var lastHandshake time.Time | ||
| if ps, ok := status.Peer[node.Key]; ok { | ||
| lastHandshake = ps.LastHandshake | ||
| } |
Contributor
There was a problem hiding this comment.
Is there a situation a peer would be missing from the configMaps peer list but still be in the engine's peer list?
Contributor
Author
There was a problem hiding this comment.
Yeah, immediately after receiving a DISCONNECTED update, we remove it from configMaps. Then until the next update it'll be in the engine but not configMaps. Probably an edge case for us to DISCONNECT and then immediately get a new NODE update, though.
tailnet/configmaps_internal_test.go
Outdated
| // Then: we don't configure | ||
| requireNeverConfigures(ctx, t, uut) | ||
|
|
||
| p1ID := uuid.MustParse("10000000-0000-0000-0000-000000000000") |
Contributor
There was a problem hiding this comment.
A nice shorthand for this is uuid.UUID{1}
3b8d264 to
b573a10
Compare
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support to configMaps to handle peer updates including lost and disconnected peers