feat: use tailnet v2 API for coordination#11638
Merged
spikecurtis merged 1 commit intomainfrom Jan 22, 2024
Merged
Conversation
This was referenced Jan 16, 2024
This was referenced Jan 16, 2024
Contributor
Author
4177202 to
04e3985
Compare
80e59bd to
fe63f6a
Compare
04e3985 to
64caaac
Compare
9a1e2eb to
2f11961
Compare
64caaac to
2bced78
Compare
2f11961 to
e611c3c
Compare
2bced78 to
afd20a0
Compare
e611c3c to
fba56d1
Compare
afd20a0 to
0b9455c
Compare
fba56d1 to
02287a9
Compare
02287a9 to
8156019
Compare
8156019 to
8a045b0
Compare
8a045b0 to
6ef3db5
Compare
coadler
approved these changes
Jan 22, 2024
Contributor
coadler
left a comment
There was a problem hiding this comment.
Looks good. Nice to see it all come together
Comment on lines
+45
to
+46
| // TODO: handle DERPMap too! | ||
| DerpMapUpdateFrequency: time.Hour, |
Contributor
There was a problem hiding this comment.
Is this needed for this PR or is it addressed in one of the PRs after this?
Contributor
Author
There was a problem hiding this comment.
Addressed in some upstack PRs. As of this PR we still use the old DERPMap dedicated websocket, but I'm in the process of switching everything over after this one.
6ef3db5 to
a3721bb
Compare
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is huge, and I'm sorry.
The problem is that once I change
tailnet.Connto start doing v2 behavior, I kind of have to change it everywhere, including in CoderSDK (CLI), the agent, wsproxy, and ServerTailnet.There is still a bit more cleanup to do, and I need to add code so that when we lose connection to the Coordinator, we mark all peers as LOST, but that will be in a separate PR since this is big enough!