feat: use v2 API for agent lifecycle updates#12278
Merged
spikecurtis merged 1 commit intomainfrom Feb 23, 2024
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikecurtis and the rest of your teammates on |
mafredri
approved these changes
Feb 23, 2024
Member
mafredri
left a comment
There was a problem hiding this comment.
Some tests need updating (relying on removed agentClient.PostLifecycle), but otherwise LGTM!
agent/agent.go
Outdated
| lastReportedIndex++ | ||
| continue | ||
| } | ||
| logger := a.logger.With(slog.F("payload", l)) |
Member
There was a problem hiding this comment.
Nit: The payload should be payload := &proto.UpdateLifecycleRequest{Lifecycle: l}, as that's what's being sent.
0e7b180 to
5586ecf
Compare
Contributor
Author
|
Thanks! Going to keep the PostLifecycle around, but deprecated so that we have tests against the v1 API. We can retire it all when we drop v1 support. |
5586ecf to
c17735d
Compare
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent uses the v2 API to post lifecycle updates.
Part of #10534