Conversation
aslilac
reviewed
Oct 7, 2025
Member
aslilac
left a comment
There was a problem hiding this comment.
luckily ignoring whitespace changes makes the diff waaaaaay smaller. 😄
seems pretty straight forward, one comment about types tho
| /> | ||
| )); | ||
|
|
||
| const _TableFooter = React.forwardRef< |
Contributor
Author
There was a problem hiding this comment.
The tables we had weren’t using it 😕
Member
There was a problem hiding this comment.
it's not really doing anything novel/complicated. I would rather we delete unused code than ignore it.
aslilac
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to break this work into smaller pieces, but since there are a lot of dependent components, I decided to handle it in one larger chunk and rely on Storybook to catch any bugs.
That said, let me know if you’d prefer a different approach!