feat: add rbac specificity for dbpurge#21088
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
… jakehwll/dbpurge-rbac-specificity
Contributor
dannykopping
left a comment
There was a problem hiding this comment.
Hell yeah 👍
It needs some tests please, though.
| { | ||
| Identifier: rbac.RoleIdentifier{Name: "dbpurge"}, | ||
| DisplayName: "DB Purge Daemon", | ||
| Site: rbac.Permissions(map[string][]policy.Action{ |
… jakehwll/dbpurge-rbac-specificity
Emyrk
approved these changes
Dec 12, 2025
| Identifier: rbac.RoleIdentifier{Name: "dbpurge"}, | ||
| DisplayName: "DB Purge Daemon", | ||
| Site: rbac.Permissions(map[string][]policy.Action{ | ||
| rbac.ResourceSystem.Type: {policy.ActionDelete}, |
Member
There was a problem hiding this comment.
Unfortunate we need system delete, but I see why
… jakehwll/dbpurge-rbac-specificity
mtojek
approved these changes
Dec 19, 2025
Member
mtojek
left a comment
There was a problem hiding this comment.
Looking good! Feel free to merge.
jakehwll
added a commit
that referenced
this pull request
Dec 19, 2025
Related to [`internal#1139`](coder/internal#1139) This implements some prometheus metrics for records being removed from the database. Currently we're tracking the following fields being removed from the DB by this. They're viewable in the `/api/v2/debug/metrics` endpoint. * `expired_api_keys` * `aibridge_records` * `connection_logs` * `duration` ``` # HELP coderd_dbpurge_iteration_duration_seconds Duration of each dbpurge iteration in seconds. # TYPE coderd_dbpurge_iteration_duration_seconds histogram coderd_dbpurge_iteration_duration_seconds_bucket{success="true",le="1"} 1 coderd_dbpurge_iteration_duration_seconds_bucket{success="true",le="5"} 1 coderd_dbpurge_iteration_duration_seconds_bucket{success="true",le="10"} 1 coderd_dbpurge_iteration_duration_seconds_bucket{success="true",le="30"} 1 coderd_dbpurge_iteration_duration_seconds_bucket{success="true",le="60"} 1 coderd_dbpurge_iteration_duration_seconds_bucket{success="true",le="300"} 1 coderd_dbpurge_iteration_duration_seconds_bucket{success="true",le="600"} 1 coderd_dbpurge_iteration_duration_seconds_bucket{success="true",le="+Inf"} 1 coderd_dbpurge_iteration_duration_seconds_sum{success="true"} 0.014787814 coderd_dbpurge_iteration_duration_seconds_count{success="true"} 1 # HELP coderd_dbpurge_records_purged_total Total number of records purged by type. # TYPE coderd_dbpurge_records_purged_total counter coderd_dbpurge_records_purged_total{record_type="aibridge_records"} 0 coderd_dbpurge_records_purged_total{record_type="audit_logs"} 0 coderd_dbpurge_records_purged_total{record_type="connection_logs"} 0 coderd_dbpurge_records_purged_total{record_type="expired_api_keys"} 0 coderd_dbpurge_records_purged_total{record_type="workspace_agent_logs"} 0 ``` | Position | Pull-request | | -------- | ------------ | | ✅ | [feat: add prometheus observability metrics for `dbpurge`](#21074) | | | [feat: add rbac specificity for `dbpurge`](#21088) |
Base automatically changed from
jakehwll/dbpurge-observability-metrics-prometheus
to
main
December 19, 2025 13:21
Contributor
|
@jakehwll the test you added works but it's overfitting. By that I mean it's basically reimplementing dbpurge by calling all of its methods. It does check that all the methods called have the appropriate RBAC permissions, but this became stale the moment it was written. When we change dbpurge behaviour (i.e. add new steps) those will either have to be reflected here or there will be a testing blindspot. Instead, I'd suggest that you extract the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to
internal#1139Continuation of #21074
This implements some RBAC role specificity for
dbpurge, ensuring that we follow the least-privileged model for removing data from the database. It is specified as following.dbpurgedbpurge