fix: handle scenario where provisionerdserver deletes task before coderd #21220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes coder/internal#1112 We introduced to provisionerdserver the ability to delete a workspace's associated task for the scenario where a user decided to delete a task workspace directly, instead of the task. This introduced a race between coderd and provisionerdserver. We accounted for this in provisionerdserver with an explicit `!errors.Is(err, sql.ErrNoRows)` but forgot to apply the same logic to coderd. In the real world this will almost never happen but it does sometimes happen during our tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes coder/internal#1112
We introduced to provisionerdserver the ability to delete a workspace's associated task for the scenario where a user decided to delete a task workspace directly, instead of the task. This introduced a race between coderd and provisionerdserver. We accounted for this in provisionerdserver with an explicit
!errors.Is(err, sql.ErrNoRows)but forgot to apply the same logic to coderd.In the real world this will almost never happen but it does sometimes happen during our tests.