feat(coderd): support deleting dev containers#21248
Merged
DanielleMaywood merged 3 commits intomainfrom Dec 24, 2025
Merged
Conversation
49794cc to
4504755
Compare
1f42081 to
23de949
Compare
4504755 to
0fcab3f
Compare
23de949 to
265aeb8
Compare
This was referenced Dec 12, 2025
68d4817 to
945545b
Compare
207bae8 to
fa53f07
Compare
fa53f07 to
930e705
Compare
| }) | ||
| return | ||
| } | ||
| if apiAgent.Status != codersdk.WorkspaceAgentConnected { |
Contributor
There was a problem hiding this comment.
nit: Add a test for this case
| defer release() | ||
|
|
||
| if err = agentConn.DeleteDevcontainer(ctx, devcontainer); err != nil { | ||
| if errors.Is(err, context.Canceled) { |
Contributor
There was a problem hiding this comment.
Is this check, correct? IIUC this is using the client's context, so this check is for the case the client cancels the request, right?
Contributor
Author
There was a problem hiding this comment.
Honestly not fully sure, this is a copy+paste of prior endpoints that do the same thing
coder/coderd/workspaceagents.go
Lines 1095 to 1115 in 930e705
Co-authored-by: Susana Ferreira <susana@coder.com>
johnstcn
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #19062
Add logic to coderd to allow deleting Dev Containers
PR Stack: