feat: add API to serve proxy certificate#21391
Merged
ssncferreira merged 29 commits intomainfrom Dec 29, 2025
Merged
Conversation
This was referenced Dec 29, 2025
Contributor
Author
Signed-off-by: Danny Kopping <danny@coder.com>
5d9569a to
fa54009
Compare
193a5a7 to
3e7e1be
Compare
Signed-off-by: Danny Kopping <danny@coder.com>
3e7e1be to
93c1d44
Compare
Contributor
ssncferreira
left a comment
There was a problem hiding this comment.
LGTM, just a comment with a test where the cert file includes both the certificate and the private key (to guarantee that we never expose the private key)
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Contributor
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes coder/internal#1184