test: use deterministic time to avoid time-based flake#21396
Merged
DanielleMaywood merged 1 commit intomainfrom Dec 29, 2025
Merged
test: use deterministic time to avoid time-based flake#21396DanielleMaywood merged 1 commit intomainfrom
DanielleMaywood merged 1 commit intomainfrom
Conversation
DanielleMaywood
commented
Dec 29, 2025
| } | ||
| workspaceBuild := workspaceBuilder.Do() | ||
|
|
||
| ctx := testutil.Context(t, testutil.WaitShort) |
Contributor
Author
There was a problem hiding this comment.
self-review: moving context closer to the first usage
johnstcn
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes coder/internal#1218
I managed to create a manual reproduction of the issue by slightly modifying the test to force
CreatedAtto have the same value for multiple app status'.The fix works by using deterministic time for the test.