fix: remove unreachable exit after error call in check_pg_schema.sh#21530
Merged
dannykopping merged 1 commit intomainfrom Jan 16, 2026
Merged
fix: remove unreachable exit after error call in check_pg_schema.sh#21530dannykopping merged 1 commit intomainfrom
dannykopping merged 1 commit intomainfrom
Conversation
The error() function in lib.sh already exits, so the exit 1 after it was unreachable and triggered a shellcheck warning.
dannykopping
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes shellcheck warning reported in #21496 (comment)
Problem
The
error()function inlib.shalready callsexit 1, so theexit 1on line 17 ofcheck_pg_schema.shwas unreachable:Solution
Remove the redundant
exit 1sinceerror()already handles exiting.