fix: do not enforce managed agent limit for non-task workspaces #21689
Conversation
Creating a workspace normally (not through task) should not trigger license task usage
5730438 to
abf819b
Compare
Documentation CheckNo Changes NeededThis is an internal bug fix that corrects managed agent limit enforcement for task workspaces. The change affects internal workspace builder logic only and has no user-facing documentation impact. Task workspace behavior and managed agent limits are already documented correctly. Automated review via Coder Tasks |
|
|
||
| var _ usage.Inserter = (*UsageInserter)(nil) | ||
|
|
||
| type UsageInserter struct { |
There was a problem hiding this comment.
Suggestion: throw in a sync.RWMutex, or make it a chan?
There was a problem hiding this comment.
Through in the mutex, it was easier.
Documentation CheckPrevious FeedbackPrevious doc-check comment was accurate - no documentation changes are needed for this PR. No Changes NeededThis PR is an internal bug fix that corrects managed agent limit enforcement logic. The change ensures that:
The fix affects only internal workspace builder logic ( The PR includes comprehensive tests in Automated review via Coder Tasks |
Co-authored-by: Cian Johnston <cian@coder.com>
Relates to coder/internal#1282
Only task workspaces have the checks in wsbuilder for violating the managed agent caps in the license.
Stopped tasks that are resumed with a regular workspace start still count as usage.