fix(coderd/provisionerdserver): correct managed agent tracking#21696
Merged
fix(coderd/provisionerdserver): correct managed agent tracking#21696
Conversation
3 tasks
johnstcn
commented
Jan 27, 2026
| return nil | ||
| } | ||
|
|
||
| func seedPreviousWorkspaceStartWithAITask(ctx context.Context, t testing.TB, db database.Store) error { |
johnstcn
commented
Jan 27, 2026
Comment on lines
-3007
to
-3019
| { | ||
| name: "current build does not have ai task but previous build did", | ||
| seedFunc: seedPreviousWorkspaceStartWithAITask, | ||
| transition: database.WorkspaceTransitionStop, | ||
| input: &proto.CompletedJob_WorkspaceBuild{ | ||
| AiTasks: []*sdkproto.AITask{}, | ||
| Resources: []*sdkproto.Resource{}, | ||
| }, | ||
| isTask: true, | ||
| expectTaskStatus: database.TaskStatusPaused, | ||
| expectHasAiTask: false, // We no longer inherit this from the previous build. | ||
| expectUsageEvent: false, | ||
| }, |
Member
Author
There was a problem hiding this comment.
review: this test case is no longer valid
johnstcn
commented
Jan 27, 2026
| Stage: []string{"Cleaning Up", "Cleaning Up", "Cleaning Up", "Cleaning Up"}, | ||
| Output: []string{ | ||
| fmt.Sprintf("Unknown ai_task_app_id %q. This workspace will be unable to run AI tasks. This may be due to a template configuration issue, please check with the template author.", taskAppID.UUID.String()), | ||
| fmt.Sprintf("Unknown ai_task_app_id %q. This workspace will be unable to run AI tasks. This may be due to a template configuration issue, please check with the template author.", unknownAppID), |
Member
Author
There was a problem hiding this comment.
review: drive-by fix to avoid getting a uuid.Nil in the log which isn't really useful here
Member
deansheather
left a comment
There was a problem hiding this comment.
The usage code looks correct, I don't know enough about tasks to comment on the other changes, though.
mafredri
approved these changes
Jan 27, 2026
Contributor
Documentation CheckNo Changes NeededThis PR corrects internal tracking logic for managed agents in the provisioner server. The change affects how Reasoning:
Automated review via Coder Tasks |
johnstcn
commented
Jan 27, 2026
Comment on lines
+3002
to
+3005
| // You can still "sort of" use a task in this state, but as we don't have | ||
| // the correct app ID you won't be able to communicate with it via Coder. | ||
| expectHasAiTask: true, | ||
| expectUsageEvent: true, |
Member
Author
There was a problem hiding this comment.
review: We decided to count "misconfigured but otherwise working".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to coder/internal#1282
Updates tracking of managed agents to be predicated instead on the presence of a related
task_idinstead of the presence of acoder_ai_taskresource.