Clarify in-place operations mirror special case behaviour#299
Merged
kgryte merged 3 commits intodata-apis:mainfrom Nov 4, 2021
Merged
Clarify in-place operations mirror special case behaviour#299kgryte merged 3 commits intodata-apis:mainfrom
kgryte merged 3 commits intodata-apis:mainfrom
Conversation
asmeurer
reviewed
Nov 3, 2021
kgryte
reviewed
Nov 3, 2021
kgryte
approved these changes
Nov 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it's ambiguous if in-place operations need to follow the special case behaviour of their standard operation (and elementwise) counter-parts. This PR notes that this indeed is the case.