Restrict linspace support to floating-point data types#393
Merged
Conversation
Contributor
Author
|
cc @honno |
honno
approved these changes
Feb 21, 2022
Member
honno
left a comment
There was a problem hiding this comment.
LGTM. Good shout on noting non-representable start and stop args.
Contributor
Author
|
As the changes in this PR are straightforward and have been discussed in consortium meetings, will go ahead and merge so that changes, if any, can be updated in the test suite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
linspaceshould be limited to floating-point output data types, unless a conforming implementation has compelling reasons for supporting integer output data types (e.g., due to backward compatibility). However, integer output behavior is left implementation-defined and should not, in general, be considered portable.intstart and stop values to floating-point. Namely, that overflow behavior is implementation-defined. This follows similar guidance elsewhere in the specification.