Ignore asserting out dtype for undefined dtypes in test_prod#122
Merged
honno merged 1 commit intodata-apis:masterfrom May 17, 2022
Merged
Ignore asserting out dtype for undefined dtypes in test_prod#122honno merged 1 commit intodata-apis:masterfrom
test_prod#122honno merged 1 commit intodata-apis:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #106 by blanket ignoring dtype assertions when what's expected doesn't exist, e.g. the default uint. Couldn't introduce a warning easily as I forgot we're using Hypothesis, so opted to do this completely silently 😅
Also ignoring dtype assertions (as well as shape assertions) before testing values isn't ideal, as it can obfuscate the core problems. Fortunately for
test_prodI can't see this being a problem with the PyTorch scenario, although other partial dtype scenarios could be problematic... but don't seem to exist!