Short-circuit with vectorisation ph.assert_array_elements()#236
Merged
honno merged 7 commits intodata-apis:masterfrom Feb 28, 2024
Merged
Short-circuit with vectorisation ph.assert_array_elements()#236honno merged 7 commits intodata-apis:masterfrom
ph.assert_array_elements()#236honno merged 7 commits intodata-apis:masterfrom
Conversation
2cfaeb7 to
7b71693
Compare
asmeurer
reviewed
Feb 27, 2024
2023.12 release!
`real` and `imag` are not properties of API arrays!
c38f7a4 to
94e716c
Compare
94e716c to
82125d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And general
test_eyeimprovements. Carries on the work by @jakevdp in #200 (separate PR to make things easier to track).RequiresLet's just ignore thesignbitreleased in the2023.12spec, which isn't even supported yet in array API adoptions likejax.experimental.array_api. Probably what I'll do is ignore asserting pos/neg zeros for most of the tests where it's not really relevant, so we get the vectorisation benefits regardless of API version and adoption. I'll leave that for a future PR as I'd just want to mull that over, and want to see what the shape of vectorising everything looks like first anywho. This PR is essentially a proof of concept to be applied everywhere possible.signbitstuff if not available as the immediate perf benefits for libraries probably always trumps testing signed zero stuff.