Skip to content

stop skipping test_divide for complex inputs#306

Merged
asmeurer merged 1 commit intodata-apis:masterfrom
ev-br:elementwise_tests
Nov 18, 2024
Merged

stop skipping test_divide for complex inputs#306
asmeurer merged 1 commit intodata-apis:masterfrom
ev-br:elementwise_tests

Conversation

@ev-br
Copy link
Member

@ev-br ev-br commented Nov 16, 2024

Address the test_divide (no complex numbers testing) part of #301

Locally tests seem to pass, so I actually wonder what was meant by the TODO comment.

@asmeurer
Copy link
Member

Not sure. It was added in ff865bc. It's possible my fix at aba096e using cmath instead of math was all that was needed.

@asmeurer asmeurer merged commit 393b69b into data-apis:master Nov 18, 2024
@ev-br ev-br mentioned this pull request Nov 19, 2024
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments