Skip to content

Ensure thrift field IDs stay within range#276

Merged
vikrantpuppala merged 1 commit intodatabricks:mainfrom
vikrantpuppala:thrift-field-test
Jun 24, 2025
Merged

Ensure thrift field IDs stay within range#276
vikrantpuppala merged 1 commit intodatabricks:mainfrom
vikrantpuppala:thrift-field-test

Conversation

@vikrantpuppala
Copy link
Collaborator

@vikrantpuppala vikrantpuppala commented Jun 17, 2025

Ensure thrift field IDs stay within range

Tested by changing a field ID to > allowed and it worked fine

Running tool: /Users/vikrant.puppala/.gvm/gos/go1.21/bin/go test -timeout 30s -run ^TestThriftFieldIdsAreWithinAllowedRange$ github.com/databricks/databricks-sql-go/internal/cli_service

=== RUN   TestThriftFieldIdsAreWithinAllowedRange
    /Users/vikrant.puppala/databricks-sql-go/internal/cli_service/thrift_field_id_test.go:49: Found Thrift field IDs that exceed the maximum allowed value of 3328.
        This can cause compatibility issues and conflicts with reserved ID ranges.
        Violations found:
          - Line 11794: Field 'maxBytesPerBatch' has ID 3356 (exceeds maximum of 3328) - MaxBytesPerBatch *int64

--- FAIL: TestThriftFieldIdsAreWithinAllowedRange (0.01s)
FAIL
FAIL    github.com/databricks/databricks-sql-go/internal/cli_service    0.841s

@vikrantpuppala
Add test to ensure thrift field IDs stay within range
039c53a 
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
gopalldb
gopalldb reviewed Jun 19, 2025
View reviewed changes
@vikrantpuppala vikrantpuppala merged commit 746c05d into databricks:main Jun 24, 2025
2 of 3 checks passed
@vikrantpuppala vikrantpuppala deleted the thrift-field-test branch June 24, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gopalldb gopalldb gopalldb approved these changes

@jadewang-db jadewang-db Awaiting requested review from jadewang-db

@jackyhu-db jackyhu-db Awaiting requested review from jackyhu-db

@deeksha-db deeksha-db Awaiting requested review from deeksha-db

@samikshya-db samikshya-db Awaiting requested review from samikshya-db

@jprakash-db jprakash-db Awaiting requested review from jprakash-db

@madhav-db madhav-db Awaiting requested review from madhav-db

@jayantsing-db jayantsing-db Awaiting requested review from jayantsing-db

@shivam2680 shivam2680 Awaiting requested review from shivam2680

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vikrantpuppala @gopalldb

Comments