Closed
Conversation
* fixes for cloud fetch Signed-off-by: Andre Furlan <andre.furlan@databricks.com> --------- Signed-off-by: Andre Furlan <andre.furlan@databricks.com> Co-authored-by: Raymond Cypher <raymond.cypher@databricks.com>
benc-db
reviewed
Feb 21, 2024
| # Download was not successful for next download item. Fail | ||
| self._shutdown_manager() | ||
| return None | ||
| raise ResultSetDownloadError( |
Collaborator
There was a problem hiding this comment.
Per the change in the comment above, there is no retry attempted?
Collaborator
There was a problem hiding this comment.
Or is it just handled by raising the exception?
Contributor
Author
There was a problem hiding this comment.
the retry is done outside this function, closer to the actual http request
Signed-off-by: Andre Furlan <andre.furlan@databricks.com>
61dda59 to
cef6cf3
Compare
benc-db
reviewed
Feb 21, 2024
| return uncompressed_data | ||
|
|
||
|
|
||
| def http_get_with_retry(url, max_retries=5, backoff_factor=2, download_timeout=60): |
Collaborator
There was a problem hiding this comment.
why are we implementing retry behavior here rather than using a Retry passed to the session?
Contributor
Author
There was a problem hiding this comment.
agreed. It is in the TODO to also have connection pools
benc-db
approved these changes
Feb 21, 2024
Collaborator
benc-db
left a comment
There was a problem hiding this comment.
Approve, but consider if we can implement with urllib3 Retry.
This was referenced Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throw when failed to download file
Retry properly while downloading file
Add a bunch of debug logs
Prevent thread issues
TODO: http connection pools for cloud storage, proxies, etc.
Also backported to version 2