Fix detailed error codes on Windows#911
Merged
yxxhero merged 2 commits intodatabus23:masterfrom Jan 24, 2026
Merged
Conversation
Switches from Powershell to cmd since Powershell hides the original exit code.
Contributor
Author
|
Oh, also: the documentation doesn't state anywhere that you need to install Powershell (pwsh.exe) instead of using "Microsoft Powershell" (powershell.exe). Not sure how to best express this in the README. Just switching the install and upgrade commands from pwsh to powershell is not an option without rewriting the install and upgrade scripts to Microsoft Powershell. So I would suggest not touching that part. |
There was a problem hiding this comment.
Pull request overview
This PR fixes a Windows-specific bug where the --detailed-exitcode flag was not returning the correct exit code (2) when changes are detected. The issue was caused by PowerShell wrapping the binary execution, which transforms all non-zero exit codes to 1.
Changes:
- Removed Windows-specific PowerShell wrapper from
platformCommandin plugin.yaml, allowing direct binary execution that preserves exit codes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches from Powershell to calling the diff.exe directly since Powershell hides the original exit code.
Fixes #910
Tested locally by editing the plugin.yaml in the plugin directory.