Skip to content

new icon: vaadin (original, original-wordmark)#2188

Merged
canaleal merged 3 commits intodevicons:developfrom
weh:feature/1003-vaadin-icon
Nov 10, 2024
Merged

new icon: vaadin (original, original-wordmark)#2188
canaleal merged 3 commits intodevicons:developfrom
weh:feature/1003-vaadin-icon

Conversation

@weh
Copy link
Contributor

@weh weh commented Apr 24, 2024

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

i think a plain-wordmark or line* version would not be allowed
https://vaadin.com/trademark

This PR closes NONE

closes #1003

Link to prove your SVG is correct and up-to-date.

https://vaadin.com/trademark

@weh weh requested review from a team, ConX, Snailedlt, canaleal and lunatic-fox and removed request for a team April 24, 2024 17:24
@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60



Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/vaadin/vaadin-original-wordmark.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

canaleal
canaleal approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍
Also yeah, it seems like only the white version is accepted as an alternative color to the SVGs. Making a line version will also go against their policy.

@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Jul 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal
Copy link
Member

canaleal commented Nov 10, 2024

No artifacts in the original SVG. Also yes, a plain version of the wordmark cannot be made without getting into trouble with Vaadin.

image

@canaleal canaleal merged commit a4e6c2f into devicons:develop Nov 10, 2024
@Snailedlt
Copy link
Collaborator

Snailedlt commented Nov 10, 2024 •
edited
Loading

@canaleal @weh it looks like plian wordmark would be allowed, considering that they showcase a mono colored wordmark at the bottom of that page:
Screenshot_2024_1110_113636.png

GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@canaleal
Merge pull request devicons#2188 from weh/feature/1003-vaadin-icon
dd038eb 
new icon: vaadin (original, original-wordmark)
@canaleal canaleal mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@canaleal canaleal canaleal approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@Snailedlt Snailedlt Awaiting requested review from Snailedlt Snailedlt was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

Assignees

No one assigned

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@weh @canaleal @Snailedlt