Fix the issue with "Post Check SVG" posting the wrong message#515
Merged
Fix the issue with "Post Check SVG" posting the wrong message#515
Conversation
This comment has been minimized.
This comment has been minimized.
amacado
approved these changes
Feb 23, 2021
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think I figure out the issue.
Here's what we want the bot to do:
Post a failure message if value is a text. This means the code is not
1akaSVG_STATUS_CODE.SVG_OKor0akaSVG_STATUS_CODE.NO_SVGHere's what the old check is:
However, this would be interpreted differently by the script. If the
error_messageis1, it will trip the first check. If theerror_messageis0, it will trip the second cause OR operators check terms until one is true.Pretty much, this is the wrong check. Using OR in human language is different than OR in computer and I forgot to "translate" it.
Here's the new check:
This will ensure that only contents that don't match both
0and1trigger the script.This should work.