Skip to content

Comments

Add support for Bitbucket Cloud and Server#23

Merged
nedtwigg merged 14 commits intodiffplug:mainfrom
bHacklv:feature/bitbucket-support
Jun 23, 2021
Merged

Add support for Bitbucket Cloud and Server#23
nedtwigg merged 14 commits intodiffplug:mainfrom
bHacklv:feature/bitbucket-support

Conversation

@bHacklv
Copy link

@bHacklv bHacklv commented Jun 21, 2021 •
edited
Loading

  • filenameSafe now removes query parameters and appends file name to the end of the link to preserve its original file extension.
  • Support for Bitbucket Cloud and Server

nedtwigg
nedtwigg requested changes Jun 21, 2021
View reviewed changes
Copy link
Member

@nedtwigg nedtwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a great PR! It has one big problem which is that it adds a new GitAnchorType BRANCH. I think that's a bad idea, but I'm happy to merge it anyway.

But! We should merge Bitbucket support without BRANCH support. Then, after that has been merged, I'd be happy to take a new PR which adds BRANCH support. I just created a new issue for mutable branch support in #24.

If you delete support for BRANCH, it will be quick and easy to get this merged. From there, it's also easy to close out #24 if you still want to.

@nedtwigg
Copy link
Member

nedtwigg commented Jun 23, 2021

I made a few tweaks:

  • instead of cloudAuth and serverAuth, users can just do auth and we can deal with it ourselves
  • using a custom domain implies server(), so we don't need to specify that ourselves
  • I made https://bitbucket.org/diffplug/blowdryer

If you're okay with these changes, I'm ready to merge and release.

@bHacklv
Copy link
Author

bHacklv commented Jun 23, 2021

I made a few tweaks:

  • instead of cloudAuth and serverAuth, users can just do auth and we can deal with it ourselves
  • using a custom domain implies server(), so we don't need to specify that ourselves
  • I made https://bitbucket.org/diffplug/blowdryer

If you're okay with these changes, I'm ready to merge and release.

lgtm!

@nedtwigg nedtwigg merged commit d0e91a9 into diffplug:main Jun 23, 2021
@nedtwigg
Copy link
Member

nedtwigg commented Jun 23, 2021

Released in 1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nedtwigg nedtwigg nedtwigg requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bHacklv @nedtwigg