Add installed jre#16
Merged
nedtwigg merged 6 commits intodiffplug:masterfrom Nov 24, 2016
scottresnik:add-installed-jre
Merged
Conversation
Member
|
For future reference, you can just run |
Member
|
Sorry, should have opened with "looks like a great feature!". I'm excited to merge it in :) |
Contributor
Author
|
Missed spotless on the last commit. Squashed the formatting commits. Left the meat. I can squash further, if desired. |
added 3 commits
November 23, 2016 22:23
…contained it within ConventionJdt. This required adding a method to OomphConvention for specifying that the block is closed, so that values which have been accumulated can be flushed into actions.
…, and give links to the more detailed stuff later.
Member
|
Thanks a ton for the great contribution! A couple questions:
|
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added functionality to specify additional JRE's to be included in the workspace.