Merged
Conversation
…o-date etc. takes longer to converge, but there was probably always a correctness race-condition anyway.
…for the configuration cache.
Member
Author
|
It actually is a big deal. It breaks the buildcache, which is more important most of the time, and adds a ton of complexity. To do this right, we would need an incremental task that does More complexity than it's worth, I think. For now, I'm just ripping out the incremental part, which makes everything else much simpler anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2.2.0was supposed to add support for configuration cache, but was actually broken. This PR fixes it, but at the following cost:InputFile mappingFileInandOutputFile mappingFileOut, the last step of the task is to writemappingFileOutand copy it back tomappingFileInOverall not a big deal.EDIT: See next comment.