highlighting: make comments, prompt and command-output non-selectable#12425
Merged
usha-mandya merged 5 commits intodocker:masterfrom Mar 2, 2021
Merged
highlighting: make comments, prompt and command-output non-selectable#12425usha-mandya merged 5 commits intodocker:masterfrom
usha-mandya merged 5 commits intodocker:masterfrom
Conversation
This tones down the prompt and command output, so that the commands to run stand out more clearly. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was only included in some distributions, so adding it to all pages. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Prevent selecting comments, command-output and command-prompt in shell examples that use the "console" lexer/highlighter to allow easier copying. See rouge-ruby/rouge#1023 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
Deploy preview for docsdocker ready! Built with commit 19b3b40 |
Member
Author
|
Also can use https://rouge-ruby.github.io/docs/Rouge/Lexers/ConsoleLexer.html to force specific shell highlighting, e.g.; |
Show a "text" cursor for the prompt. Even though the prompt itself is not selectable, make it appear as if it is, so that users don't get confused when they try to select an example for copying. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
@usha-mandya updated; I pushed a change to make the prompt itself have a "text" cursor, as discussed |
Member
|
Thanks @thaJeztah. Happy with the improvements We can fix the prompt appearing when copy/pasting two blocks in a subsequent patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #5380 and #5282 (and others)
Prevent selecting comments, command-output and command-prompt in shell
examples that use the "console" lexer/highlighter to allow easier copying.
See rouge-ruby/rouge#1023
The "comment" and "command-output" non-selectable may be ones we need to keep an eye on, to check if it properly detects commands from "output" and "comments"
Before this:
After this: