feat: allows relative path, fixed #590#714
Merged
timaschew merged 2 commits intodocsifyjs:masterfrom Apr 7, 2019
Merged
Conversation
Member
|
Any plans to merge this PR (before 5.0)? |
Author
|
@timaschew any plan to merge this one ? :) |
Member
|
@sansnom I've created today a PR (not merged yet) providing a test environment in order to verify that we don't introduce new bugs when changing anything. Would be nice if we can have some tests for this feature as well. If you |
timaschew
requested changes
Jan 30, 2019
timaschew
reviewed
Mar 19, 2019
Author
|
Anyone to recheck and merge this ? :) I've added some unit test. Thanks ! |
Member
Author
@timaschew Glad to see #603 has been resolved and the project can continue. :) |
Member
|
@sansnom sorry for the delay. I will merge it this weekend. |
timaschew
approved these changes
Apr 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
It's the same PR as #593 thanks to @NoCLin which allows relative path (fix #590). But I've added an option relativePath to enable it (like proposed in #657). By default it's disabled so it's backward compatible: no breaking changes. :)
I've tried to add some documentation, I hope it's clear enough.
Please makes sure these boxes are checked before submitting your PR, thank you!
masterbranch.libdirectory.