Detect if RSA-384 is supported on the platform#120366
Merged
vcsjones merged 3 commits intodotnet:mainfrom Oct 3, 2025
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
Member
|
It's draft, but currently LGTM (FWIW). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes RSA-384 support detection across different RSA provider implementations by introducing a new PlatformSupport.IsRSA384Supported property. The change eliminates duplicated platform detection logic and provides a unified approach for determining RSA-384 support.
Key changes:
- Added centralized RSA-384 support detection in
PlatformSupportclass - Replaced provider-specific RSA-384 support checks with calls to the centralized property
- Removed duplicated platform detection code from individual RSA provider classes
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/libraries/Common/tests/System/Security/Cryptography/PlatformSupport.cs |
Added IsRSA384Supported property with platform-specific detection logic and RSA-384 test parameters |
src/libraries/System.Security.Cryptography/tests/DefaultRSAProvider.cs |
Replaced custom RSA-384 support detection with centralized PlatformSupport.IsRSA384Supported |
src/libraries/System.Security.Cryptography.Csp/tests/RSACryptoServiceProviderProvider.cs |
Changed from hardcoded true to use centralized RSA-384 support detection |
src/libraries/System.Security.Cryptography.Cng/tests/RSACngProvider.cs |
Replaced custom RSA-384 support detection with centralized PlatformSupport.IsRSA384Supported |
src/libraries/Common/tests/System/Security/Cryptography/PlatformSupport.cs
Show resolved
Hide resolved
bartonjs
approved these changes
Oct 3, 2025
Member
Author
|
The Windows pipeline did not have these failures so enabled automatic merge. |
Member
Author
|
/backport to release/10.0 |
Member
Author
|
/backport to release/9.0-staging |
Contributor
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18232060822 |
Contributor
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/18232062344 |
Contributor
|
@vcsjones backporting to "release/10.0" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Detected is RSA-384 is supported on the platform
Using index info to reconstruct a base tree...
M src/libraries/Common/tests/System/Security/Cryptography/PlatformSupport.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/Common/tests/System/Security/Cryptography/PlatformSupport.cs
CONFLICT (content): Merge conflict in src/libraries/Common/tests/System/Security/Cryptography/PlatformSupport.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Detected is RSA-384 is supported on the platform
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Contributor
|
@vcsjones backporting to "release/9.0-staging" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Detected is RSA-384 is supported on the platform
Using index info to reconstruct a base tree...
M src/libraries/Common/tests/System/Security/Cryptography/PlatformSupport.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/Common/tests/System/Security/Cryptography/PlatformSupport.cs
Applying: Fix M.B.C compilation
Using index info to reconstruct a base tree...
M src/libraries/Microsoft.Bcl.Cryptography/tests/Microsoft.Bcl.Cryptography.Tests.csproj
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/Microsoft.Bcl.Cryptography/tests/Microsoft.Bcl.Cryptography.Tests.csproj
CONFLICT (content): Merge conflict in src/libraries/Microsoft.Bcl.Cryptography/tests/Microsoft.Bcl.Cryptography.Tests.csproj
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 Fix M.B.C compilation
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Member
Author
|
Boo. This would backport cleanly if the patch was squashed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #120353