Merged
Conversation
sharwell
reviewed
Dec 29, 2019
sharwell
left a comment
There was a problem hiding this comment.
I reviewed 30/66 files. If you want me to finish the complete review let me know. 😄
| [Required] | ||
| public ITaskItem SourceRoot { get; set; } | ||
| [Required, NotNull] | ||
| public ITaskItem? SourceRoot { get; set; } |
There was a problem hiding this comment.
💡 Since this property is [Required], you can remove the NotNull and ? and instead use this pattern:
Member
Author
There was a problem hiding this comment.
Not sure I like the other pattern better. Is there a benefit?
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <LangVersion>Preview</LangVersion> | |||
Member
Author
There was a problem hiding this comment.
I want to keep using the latest features even when in preview.
| [Required] | ||
| public string ProjectDirectory { get; set; } | ||
| [Required, NotNull] | ||
| public string? ProjectDirectory { get; set; } |
There was a problem hiding this comment.
💡 These can both be marked non-null using the pattern shown above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.