Skip to content

Add Python 3.12 to our test matrix.#807

Merged
lovelydinosaur merged 1 commit intoencode:masterfrom
hugovk:master
Sep 18, 2023
Merged

Add Python 3.12 to our test matrix.#807
lovelydinosaur merged 1 commit intoencode:masterfrom
hugovk:master

Conversation

@hugovk
Copy link
Contributor

@hugovk hugovk commented Sep 17, 2023

Summary

The second Python 3.12 release candidate is out! 🚀

Call to action

We strongly encourage maintainers of third-party Python projects to prepare their projects for 3.12 compatibilities during this phase, and where necessary publish Python 3.12 wheels on PyPI to be ready for the final release of 3.12.0.

Python 3.12.0 final is due out in two weeks: 2023-10-02.

See also https://dev.to/hugovk/help-test-python-312-beta-1508/

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

lovelydinosaur
lovelydinosaur approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@lovelydinosaur lovelydinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😊

@lovelydinosaur lovelydinosaur merged commit 6071ea7 into encode:master Sep 18, 2023
@karpetrosyan
Copy link
Contributor

karpetrosyan commented Sep 18, 2023

Did you forget a changelog?

@lovelydinosaur
Copy link
Contributor

lovelydinosaur commented Sep 18, 2023

Okay let me slow this down a little and be more precise.

First up, we should change the title of this PR...

@lovelydinosaur lovelydinosaur changed the title Add support for Python 3.12 Add Python 3.12 to our test matrix. Sep 18, 2023
@lovelydinosaur
Copy link
Contributor

lovelydinosaur commented Sep 18, 2023

...okay that's better.

@lovelydinosaur
Copy link
Contributor

lovelydinosaur commented Sep 18, 2023

Did you forget a changelog?

Good thing to check, thanks. No we don't need a CHANGELOG entry here.
We're not adding 3.12 support, we're including it in our CI tests.

@hugovk
Copy link
Contributor Author

hugovk commented Sep 18, 2023

This PR also added the Trove classifier for 3.12, which could be seen as adding 3.12 support?

I think it's a good time to add it: the final 3.12 RC3 is due out today, the full release in two weeks, and there should be no changes between now and then, and no ABI changes allowed.

@lovelydinosaur
Copy link
Contributor

lovelydinosaur commented Sep 19, 2023

This PR also added the Trove classifier for 3.12, which could be seen as adding 3.12 support?

Ah thats a good point, thanks @hugovk.

Yes a CHANGELOG entry noting that our package now explicitly indicates 3.12 support would be valid.

Related... anyone up for an equivalent pull request to httpx?

This was referenced Sep 19, 2023
Merged
Merged
@hugovk
Copy link
Contributor Author

hugovk commented Sep 19, 2023

This PR also added the Trove classifier for 3.12, which could be seen as adding 3.12 support?

Ah thats a good point, thanks @hugovk.

Yes a CHANGELOG entry noting that our package now explicitly indicates 3.12 support would be valid.

Here we go! #810

Related... anyone up for an equivalent pull request to httpx?

And here we go again! encode/httpx#2854

@karpetrosyan karpetrosyan mentioned this pull request Sep 19, 2023
Merged
1 task
@T-256 T-256 mentioned this pull request Sep 19, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lovelydinosaur lovelydinosaur lovelydinosaur approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk @karpetrosyan @lovelydinosaur

Comments