Pin CI version of click to resolve mypy error#2769
Merged
Conversation
Contributor
|
It looks like a release in click will happen soon, fyi |
Contributor
Author
|
I tried the linked pull request locally and it didn't work — figure we might as well be unblocked in the meantime but don't have strong feelings. |
Contributor
|
Ah well caught. We'd probably want to resolve a CI failure by pinning in
Yep. |
Contributor
Author
|
@tomchristie done! |
Kludex
approved these changes
Jul 12, 2023
click to resolve mypy error
samclearman
pushed a commit
to titanmsp/httpx
that referenced
this pull request
Apr 26, 2025
* Add upper bound to click version to fix mypy error * Move pin to `requirements.txt` * Restore `pyproject.toml`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is failing (e.g. #2768) because of a mypy/click bug ref pallets/click#2558
This is resolves the type error by temporarily adding a bound to the supported click version and can be reverted once the bug is fixed upstream.
Additional refs pallets/click#2559 pallets/click#2562 python/mypy#13449