Support newer versions of httpcore#2885
Conversation
httpcore 1.0.0 was release October 6, 2023.
|
Thanks. 🙂 So... from Although actually we want to push through and have See #2858 |
Co-authored-by: Kar Petrosyan <92274156+karpetrosyan@users.noreply.github.com>
|
Referring back to my previous review :) This pull request should require both 'httpcore' and 'anyio'. (Effectively the same as requiring 'httpcore[asyncio]') Actually what we really want is PR #2858, which addresses this more comprehensively with the async dependencies no longer included by default. Tho we can treat that as a follow-up aimed at the upcoming 1.0 release. See #947 (comment) |
lovelydinosaur
left a comment
There was a problem hiding this comment.
My suggestion here would be...
- Either add
anyioto the dependencies list, or usehttpcore[asyncio]. - Add "update httpcore dependency" to the CHANGELOG.
And then we follow up with a new minor point release.
|
I'm happy to roll a minor point release with this if the above suggestions are resolved. (We'll do that either way, but we can have an interim release if we want.) |
Co-authored-by: Tom Christie <tom@tomchristie.com>
|
Okay I think if we update the |
| dependencies = [ | ||
| "certifi", | ||
| "httpcore>=0.18.0,<0.19.0", | ||
| "httpcore", |
There was a problem hiding this comment.
Don't we need to pin version for httpcore and anyio here?
There was a problem hiding this comment.
If we want pinning here then...
- We should probably pin anyio to the
>=4.0.0,<5.0.0range. - We can pin httpcore to the
>=1.0.0,<2.0.0range. (Actually I think we can go lower than that, but...)
* Support newer versions of httpcore httpcore 1.0.0 was release October 6, 2023. * Update pyproject.toml * Update pyproject.toml Co-authored-by: Kar Petrosyan <92274156+karpetrosyan@users.noreply.github.com> * Update pyproject.toml Co-authored-by: Tom Christie <tom@tomchristie.com> * Update CHANGELOG.md --------- Co-authored-by: Tom Christie <tom@tomchristie.com> Co-authored-by: Kar Petrosyan <92274156+karpetrosyan@users.noreply.github.com>
Summary
Support newer versions of httpcore. httpcore 1.0.0 was release October 6, 2023.
Fixes #2884.