Warn with stacklevel=2 to show caller of deprecation#3136
Merged
lovelydinosaur merged 1 commit intoencode:version-1.0from Oct 17, 2024
Merged
Warn with stacklevel=2 to show caller of deprecation#3136lovelydinosaur merged 1 commit intoencode:version-1.0from
stacklevel=2 to show caller of deprecation#3136lovelydinosaur merged 1 commit intoencode:version-1.0from
Conversation
Contributor
Author
|
Oops, didn't mean to close this, it was autoclosed when I reset my |
Contributor
|
Thanks @hugovk - I think a number of these are removed from the |
Contributor
Author
|
Nice, all but three have been removed. I've rebased on |
Contributor
|
Thanks Hugo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With httpx==0.27.0, I'm getting deprecation warnings like:
This points to where the deprecated code is in HTTPX and isn't actionable for me.
Instead, if would be more helpful to point to where the deprecated code is being called from, so I can fix my code (or report to the library).
Adding
stacklevel=2gives:(Aha, so Litestar needs fixing! And they've already fixed and released: litestar-org/litestar#3140, I just need to update 👍)
Digging a big deeper, I see there used to be a helper function in
httpx/_utils.py:It was introduced in #963, and removed in #1597.
Should we add it back?
Checklist