Cleanup Request method parameter.#3378
Merged
lovelydinosaur merged 5 commits intomasterfrom Oct 29, 2024
Merged
Conversation
karpetrosyan
approved these changes
Oct 29, 2024
Closed
Merged
Contributor
|
Oh, it seems this change was breaking and affected the compatibility of another library with httpx. It looks like we should take changes that require a major release a bit more seriously. This kind of change breaks specific versions of other projects, without giving them any chance to avoid it :c |
Contributor
Author
|
Thanks @karpetrosyan, good to see type checker checking types.
Hishel is looking really smart. Most obvious action points...
|
samclearman
pushed a commit
to titanmsp/httpx
that referenced
this pull request
Apr 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Request()class currently has amethodparameter that's out of sync withclient.request(...)andhttpx.request(...). This is nominally an API change, tho I think it's actually a bugfix in practice.