Conversation
Closed
…ncode/httpx into version-0.28-deprecations-only
Contributor
Author
|
For comparison, SSL implementation before and after. Revised documentation is here... https://github.com/encode/httpx/blob/version-0.28-deprecations-only/docs/advanced/ssl.md |
Contributor
Author
|
Oh... one other thing... we should probably also drop Python 3.8 support here, as EOL. |
zanieb
approved these changes
Nov 28, 2024
Contributor
zanieb
left a comment
There was a problem hiding this comment.
Love deprecation warnings :)
zanieb
reviewed
Nov 28, 2024
Contributor
|
I would suggest waiting until 1.0 to drop 3.8 support, since it's not really costing us anything. (But I don't feel strongly) |
…ncode/httpx into version-0.28-deprecations-only
Contributor
Author
I can work with that, yep. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay, here's version 0.28 with nice clean deprecations for our more constrained SSL API...
0.28.0 (28th November, 2024)
The 0.28 release includes a limited set of deprecations.
Deprecations:
We are working towards a simplified SSL configuration API.
For users of the standard
verify=Trueorverify=Falsecases, orverify=<ssl_context>case this should require no changes. The following cases have been deprecated...verifyargument as a string argument is now deprecated and will raise warnings.certargument is now deprecated and will raise warnings.Our revised SSL documentation covers how to implement the same behaviour with a more constrained API.
The following changes are also included:
proxiesargument has now been removed.appargument has now been removed.certifiandhttpcoreare only imported if required. (made dependencies on certifi and httpcore only load when required #3377)socks5has a valid proxy scheme. (add socks5h proxy support #3178)Request()method signature in line withclient.request()andhttpx.request(). (CleanupRequestmethod parameter. #3378)