Handle IMAGE_REL_PPC_ADDR32 size in Coff#320
Merged
encounter merged 4 commits intoencounter:mainfrom Jan 25, 2026
Merged
Conversation
LagoLunatic
reviewed
Jan 16, 2026
Comment on lines
+347
to
+349
| pe::IMAGE_REL_PPC_REFHI => 2, | ||
| pe::IMAGE_REL_PPC_REFLO => 2, | ||
| pe::IMAGE_REL_PPC_REL24 => 3, |
Collaborator
There was a problem hiding this comment.
Do you know if IMAGE_REL_PPC_REFHI IMAGE_REL_PPC_REFLO and IMAGE_REL_PPC_REL24 used as data relocations? Their names sound like they would be code relocations, and this function (data_reloc_size) is only called for data relocations, I'm not sure that they need to be handled here like the data relocation IMAGE_REL_PPC_ADDR32.
Owner
|
Seconding Lago's comment: I think all that needs to be added here is ADDR32. The other relocation types will not be used in a data context, afaik. |
Owner
|
I am just going to merge this and fix it on main. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COFF IMAGE_REL_PPC_ADDR32 was being handled as 1 byte.
There's other relocation flags that should be probably be handled but I'm not sure off the top of my head what they're supposed to be so I'm just PR'ing this.Edit: IMAGE_REL_PPC_REFHI IMAGE_REL_PPC_REFLO IMAGE_REL_PPC_REL24