Better COFF String Detection and Big Endian Wide Strings#321
Merged
encounter merged 4 commits intoencounter:mainfrom Jan 25, 2026
Merged
Better COFF String Detection and Big Endian Wide Strings#321encounter merged 4 commits intoencounter:mainfrom
encounter merged 4 commits intoencounter:mainfrom
Conversation
LagoLunatic
reviewed
Jan 16, 2026
objdiff-core/src/arch/mod.rs
Outdated
Comment on lines
193
to
196
| // Inline loop to strip all trailing "\0" | ||
| while let Some(stripped) = string.strip_suffix('\0') { | ||
| string = stripped.to_string(); | ||
| } |
Collaborator
There was a problem hiding this comment.
Would something like
Suggested change
| // Inline loop to strip all trailing "\0" | |
| while let Some(stripped) = string.strip_suffix('\0') { | |
| string = stripped.to_string(); | |
| } | |
| string = string.trim_end_matches('\0'); |
still work here? Might be able to remove the while loop if it does.
Contributor
Author
There was a problem hiding this comment.
Let me give it a go ¯_(ツ)_/¯ My ability to code Rust is comparable to a child learning to walk at the moment.
Owner
|
Thanks for the fix, I ended up reworking the function further, hopefully it's more robust now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect the
$SGprefix for strings.Wide strings decode the full string buffer but trims excess null terminators instead of trying to decode the ascii buffer with the null terminators already taken out. Fixes issue with big endian wide strings not working properly.
Before:
After:
