ENH: Update copybutton image to match GitHub#155
Merged
choldgraf merged 4 commits intoexecutablebooks:masterfrom Jan 19, 2022
Merged
ENH: Update copybutton image to match GitHub#155choldgraf merged 4 commits intoexecutablebooks:masterfrom
choldgraf merged 4 commits intoexecutablebooks:masterfrom
Conversation
pradyunsg
previously approved these changes
Jan 19, 2022
Member
|
I’m glad that GH changed things! Honestly, I think even plain text is actually great, as long as the theme supports it: https://www.gatsbyjs.com/docs/how-to/local-development/environment-variables/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates our icon to use the "copy" copybutton from tabular. It's more in-line with how GitHub styles copy buttons, which is the major inspiration for the design here as well.
I also vaguely remember @pradyunsg saying he thought this was a better design 😅
closes #151