FIX: Make copybutton remain for a second during success#176
Merged
choldgraf merged 2 commits intoexecutablebooks:masterfrom Nov 15, 2022
Merged
FIX: Make copybutton remain for a second during success#176choldgraf merged 2 commits intoexecutablebooks:masterfrom
choldgraf merged 2 commits intoexecutablebooks:masterfrom
Conversation
choldgraf
commented
Nov 15, 2022
Member
Author
|
Gonna self-merge since this fixes a little UX bug and isn't too complex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the copybutton remain on the screen when the
.successclass is still present. It also staggers the timout of whensuccessis removed to be before the icon changes back, so that we don't get an ugly "icon change back before it hides" effect.closes #175