Tags: facebook/buck2
Tags
Add RunFailureEvent support for Android instrumentation tests Summary: Fixes issue in S468897 where instrumentation test crashes incorrectly report as PASS with skipped individual tests instead of FATAL with error details. Added RunFailureEvent to TPX test result output spec to handle testRunFailed() callbacks. This enables proper crash reporting in instrumentation tests: - Added RunFailureStatus enum (TIMEOUT=1, FATAL=2) - Added RunFailureEvent class with JSON serialization - Added sendRunFailure() method to TestResultsOutputSender - Implemented testRunFailed() in `InstrumentationTpxStandardOutputTestListener` to send `FATAL` events with crash details and device logcat traces The TPX parser (D90715950) now supports run_failure events, so this completes the end-to-end fix. Note: This diff does not enable TPX Standard out for AIT. This will happen in a subsequent diff after testing Reviewed By: NavidQar Differential Revision: D91835499 fbshipit-source-id: 5953d795fca0c8edb9516db44ac3ae98447c9e3e
Propagate ConditionalModifierInfo from config_setting with single con… …straint Summary: RFC: https://fb.workplace.com/groups/buck2dev/permalink/4179858482302192/ --------- Extend `config_setting` to return a `ConditionalModifierInfo` provider when the `config_setting `has exactly one constraint value. This allows single-constraint `config_settings` to be used as modifiers, inheriting the conditional modifier behavior. Differential Revision: D89706595 fbshipit-source-id: c4e039a18b0036b38a5a4aee5bce686b576d4394
Use content-based paths by default for core rules built for Android Summary: Fixed issues that caused it to be reverted last time, so let's try again. Reviewed By: NavidQar Differential Revision: D90863949 fbshipit-source-id: d753caf18482214d14e13e10600194859b869dae
prepare Summary: Fix build-errors Reviewed By: echistyakov Differential Revision: D90024680 fbshipit-source-id: 1bc23dabd60efdca34a19b369b322898042f5deb
Add arvr to the configuration string Reviewed By: IanChilds Differential Revision: D89144660 fbshipit-source-id: 066805d1a4a94839a9aa660a60d744e2d761c755
Some updates to the `buck2` load docs Summary: Some minor changes and tweaks. I still do not like the section on loading custom rules - it seems superfluous and does not add value..but also I cannot see good reason to delete it. Reviewed By: Wilfred Differential Revision: D88073891 fbshipit-source-id: 8529245d285cd333aa3b6de77a1edb4c0e0ac284
Make all swift anon targets content based hashed Summary: TSIA For the anon targets, we could not use `get_uses_experimental_content_based_path_hashing(ctx)` to determine whether we enable content based paths to them (as demonstrated in D86439116) The reason is that the current setup of rolling out the feature is on a per app basis by adding a modifier to the app's target platform. The issue that brings is that any dependency that is built against the execution platform won't get that information, causing them to still have content based paths disabled. Then, when come to anon targets, if target A and target B both depends on anon target X, if A has content based path enabled and B has it disabled, this would cause an inconsistent state for target X, which leads to a duplicate entry in modulemap.json (https://www.internalfb.com/intern/diffing/?paste_number=2028864153), and hence causing build failures. The solution, as described by the updated rollout plan: https://docs.google.com/document/d/1tS5CUQ8Xdpx6-hbsUx6NoGXd4VpuZu7FeXtXfHVGoRo/edit?tab=t.0, is that we will be a bit more aggressive in our rollout strategy and just enable content based path by default to the targets that are causing issues. #buildall-fbobjc Reviewed By: benb Differential Revision: D86690264 fbshipit-source-id: 3c976288fee84cc24cbbee6b2067badb9a65825a
Fix incompatible target blocking generation Summary: This command `fbpython arvr/tools/buck/vsgo --vs2022 --no-open --mode_files arvr/apps/hsr/mode/vsgo_dev --generated_folder=C:\\open\\generated_projects //arvr/projects/hsr/... //arvr/apps/hsr/demo/... //arvr/apps/hsr/example/... //arvr/apps/hsr/holodeck/...` is blocking hsr stable because a newly introduced incompatible target blocked the generation. Properly handle this in vsgo Reviewed By: autozimu Differential Revision: D85915868 fbshipit-source-id: f5b5bb7494348fa0bc87c6d44eddaeb387db0c04
Add tags and cli args to CommandStart Summary: Want to add tags to know if memory-tracker-enabled is set for lost builds. CLI args just nice to have, mostly for the UI, but is easy to add at the same time. Reviewed By: JakobDegen Differential Revision: D84556257 fbshipit-source-id: 55a5959097da7b6516c905066d98942f58914e5a
Apply race/asan flags when filter source files Summary: Bug repot: https://fb.workplace.com/groups/codegophers/permalink/29592458917042675/ Reviewed By: RollerMatic Differential Revision: D83609821 fbshipit-source-id: 9c11ea46ae1722ef1aafc439fe0d922fa1d42dd8
PreviousNext