Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for building macOS binaries in the release workflow by introducing a new platform selection option. The workflow now allows users to choose between Linux and Mac builds during manual dispatches, while tag pushes continue to build only Linux binaries by default.
Changes:
- Added a
platforminput parameter to the workflow with options for 'linux' and 'mac' - Restructured the build matrix to include both Linux and Mac targets with platform-specific configurations
- Implemented platform filtering logic to skip jobs based on trigger type and selected platform
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Build binaries (Mac) | ||
| if: steps.platform-check.outputs.skip != 'true' && matrix.platform == 'mac' | ||
| env: | ||
| # Workaround for runng-sys CMake compatibility issue |
There was a problem hiding this comment.
Corrected spelling of 'runng' to 'rung'.
| - name: Build binaries (Mac) | ||
| if: steps.platform-check.outputs.skip != 'true' && matrix.platform == 'mac' | ||
| env: | ||
| # Workaround for runng-sys CMake compatibility issue |
There was a problem hiding this comment.
The comment mentions this is a workaround for runng-sys CMake compatibility, but there's no explanation of why version 3.5 is needed or what specific issue this addresses. Adding context about the compatibility problem would help future maintainers understand when this workaround can be removed.
| # Workaround for runng-sys CMake compatibility issue | |
| # Workaround for runng-sys CMake compatibility issue: | |
| # - GitHub macOS runners ship a newer CMake that defaults to newer policy behavior. | |
| # - The runng-sys build expects older CMake policies and fails when the newer | |
| # policies are in effect (see CMake policy warnings/errors during cargo build). | |
| # - Setting CMAKE_POLICY_VERSION_MINIMUM to 3.5 forces CMake to use a baseline | |
| # of policies that are compatible with runng-sys on macOS. | |
| # Remove this once runng-sys has been updated to support newer CMake policy versions | |
| # and builds cleanly on the default CMake version of GitHub macOS runners. |
📝 Summary
Added a new option to generate Mac builds.
Resolves #858
✅ I have completed the following steps:
make lintmake test