Skip to content
This repository was archived by the owner on Sep 25, 2025. It is now read-only.

Comments

Fix/update readme#131

Merged
xarielx merged 5 commits intofreeCodeCamp:masterfrom
xarielx:fix/update-readme
Oct 23, 2019
Merged

Fix/update readme#131
xarielx merged 5 commits intofreeCodeCamp:masterfrom
xarielx:fix/update-readme

Conversation

@xarielx
Copy link
Contributor

@xarielx xarielx commented Oct 23, 2019

  • I have read Chapter's contributing guidelines.
  • My pull request has a descriptive title (not a vague title like Update README.md).
  • My pull request targets the master branch of Chapter.

Closes #123

Modified Readme to include the use of utilizing functional components with hooks in react, as well as a link to the introduction of these in the React page.

@allella
Copy link
Contributor

allella commented Oct 23, 2019

Since, there's 1 bullet point, how about we convert this to bullets for each technology, like

A React frontend using:

  • JavaScript/TypeScript
  • CSS (not Sass)
  • Functional Components with Hooks

Copy link
Contributor

@ScottBrenner ScottBrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to remove these extra spaces.

README.md Outdated
* [Node.js](https://nodejs.org) / [Express](https://expressjs.com) for our backend using JavaScript/TypeScript
* [Postgres](https://www.postgresql.org) with [Sequelize ORM](https://sequelize.org)
* [Elasticsearch](https://www.elastic.co/what-is/elasticsearch)
* A [React](https://reactjs.org/) frontend using JavaScript/TypeScript and CSS (not Sass)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* A [React](https://reactjs.org/) frontend using JavaScript/TypeScript and CSS (not Sass)
* A [React](https://reactjs.org/) frontend using JavaScript/TypeScript and CSS (not Sass)

README.md Outdated
* [Elasticsearch](https://www.elastic.co/what-is/elasticsearch)
* A [React](https://reactjs.org/) frontend using JavaScript/TypeScript and CSS (not Sass)
* Utilizing Functional Components with [Hooks](https://reactjs.org/docs/hooks-intro.html)
* [Next.js](https://nextjs.org/) for server-side rendering
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Next.js](https://nextjs.org/) for server-side rendering
* [Next.js](https://nextjs.org/) for server-side rendering

Co-Authored-By: Scott Brenner <scott@scottbrenner.me>
@allella
Copy link
Contributor

allella commented Oct 23, 2019

@ScottBrenner how are you submitting those diffs / suggestions? Are you checking out the PR and pushing changes to the PR branch? I'm new here :)

@ScottBrenner
Copy link
Contributor

@allella See step 6 here for details on how to create them (as a PR reviewer) and here for committing suggested changes (as a PR author)!

@allella
Copy link
Contributor

allella commented Oct 23, 2019

@xarielx looking better. I think the [] and () may be reversed because the typescriptlang.org URL is visible in this latest change.

Copy link
Contributor

@ScottBrenner ScottBrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This space breaks the hyperlink.

Co-Authored-By: Scott Brenner <scott@scottbrenner.me>
@xarielx
Copy link
Contributor Author

xarielx commented Oct 23, 2019

This space breaks the hyperlink.

Thanks!

@xarielx xarielx merged commit c63f1bd into freeCodeCamp:master Oct 23, 2019
@xarielx xarielx deleted the fix/update-readme branch October 23, 2019 04:02
@ScottBrenner
Copy link
Contributor

Remember to squash when merging into master, please!

@xarielx
Copy link
Contributor Author

xarielx commented Oct 23, 2019

I apologize for that @ScottBrenner, you're completely right, that will never happen again, I assumed it was squashing by default.

@nik-john
Copy link
Contributor

@all-contributors please add @xarielx for doc

@allcontributors
Copy link
Contributor

@nik-john

I've put up a pull request to add @xarielx! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

React Class Components VS Functional Components w/hooks

4 participants