This repository was archived by the owner on Sep 25, 2025. It is now read-only.
Nik john/add material ui ssr#158
Merged
nik-john merged 8 commits intofreeCodeCamp:masterfrom Nov 1, 2019
Merged
Conversation
timmyichen
approved these changes
Oct 31, 2019
| font-size: 50px; | ||
| color: ${({ theme }) => theme.colors.primary}; | ||
| `; | ||
|
|
Contributor
There was a problem hiding this comment.
can we add back in some example of using styled components for future contributors?
Contributor
|
thoughts about folder structure? My preference would be |
Contributor
Author
|
@ThomasRoest Agreed. Not sure why we didn't do that already, but I've made the change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update README.md).masterbranch of Chapter.Material UI stylesheet also need to be rendered on the server side. This PR adds this change and adds a sample component as per Official Material UI Docs