Enable analysis summary v2 and sub-language file coverage information on GHES#1967
Merged
henrymercer merged 8 commits intomainfrom Oct 27, 2023
Merged
Enable analysis summary v2 and sub-language file coverage information on GHES#1967henrymercer merged 8 commits intomainfrom
henrymercer merged 8 commits intomainfrom
Conversation
aeisenberg
reviewed
Oct 25, 2023
angelapwen
previously approved these changes
Oct 26, 2023
Contributor
angelapwen
left a comment
There was a problem hiding this comment.
Looks good, thanks for the 🧹 cleanup on failed SARIF too!
Contributor
Author
|
Now I get an opportunity to use #1971 :) |
Contributor
Author
|
Well, I'm not too surprised that didn't work. Pushing a fix. |
Contributor
|
Ah.. I'd also thought that it'd check out the current branch by default, but it does make sense that the checkout action isn't aware of the current branch ref. |
aeisenberg
approved these changes
Oct 26, 2023
Contributor
Author
I think it checks out the synthetic merge commit vs the head of the branch, and the latter is what we want to push to. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Merge / deployment checklist