start-proxy: Skip proxy setup if no credentials are available#2724
Merged
marcogario merged 3 commits intomainfrom Jan 28, 2025
Merged
start-proxy: Skip proxy setup if no credentials are available#2724marcogario merged 3 commits intomainfrom
marcogario merged 3 commits intomainfrom
Conversation
434735a to
f057e79
Compare
f057e79 to
7d7758b
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/start-proxy-action.ts:104
- The new condition for skipping proxy setup may lack test coverage. Consider adding a test to confirm the function returns early when no credentials are found.
if (credentials.length === 0) {
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
aeisenberg
previously approved these changes
Jan 24, 2025
dfe3919 to
76622e7
Compare
aeisenberg
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting up the proxy can lead to some failures as we need to download and unpack the proxy and start it. To avoid the unnecessary risk and time, we avoid setting it up if no credential was provided.
We cannot do this directly in the workflow file for two reasons. 1) you cannot write a conditional on a secret and 2) we do filter the content of the secret by ecosystem, so we need a bit more logic to do this correctly.
Merge / deployment checklist