Merged
Conversation
This commit changes overlay database creation to use the --overlay-changes flag. It also implements Git-based file change detection to generate the list of files to extract for the overlay database.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the overlay database creation to use the new --overlay-changes flag and implements Git-based file change detection. The key changes include:
- Renaming parameters in the Git command functions for improved clarity.
- Adding new functions to retrieve Git file OIDs and compute file changes for overlay databases.
- Modifying the CodeQL command functions to use the overlay changes file and base database OIDs file.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/git-utils.js | Parameter renaming and addition of getFileOidsUnderPath. |
| src/git-utils.ts | Parameter renaming and addition of getFileOidsUnderPath. |
| src/overlay-database-utils.ts | New functions for writing and reading Git OIDs and overlay changes. |
| lib/overlay-database-utils.js | ES module implementation of overlay database utilities. |
| src/codeql.ts | Updates to use --overlay-changes flag and base OIDs file. |
| lib/codeql.js | Similar updates as in src/codeql.ts. |
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Member
NlightNFotis
left a comment
There was a problem hiding this comment.
From a cursory look, this looks alright, but I would feel much more confident approving this if it came accompanied with some tests.
Contributor
Author
|
@NlightNFotis I added comments and tests as you suggested. PTAL. Thanks! |
NlightNFotis
approved these changes
Mar 21, 2025
Member
NlightNFotis
left a comment
There was a problem hiding this comment.
LGTM, what I've seen makes sense to me. Thank you for the work here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes overlay database creation to use the
--overlay-changesflag. It also implements Git-based file change detection to generate the list of files to extract for the overlay database.Merge / deployment checklist