Merged
Conversation
henrymercer
reviewed
Aug 12, 2025
.github/copilot-instructions.md
Outdated
Comment on lines
19
to
20
| - In PRs that match the release-PR patterns above: | ||
| - Review only the following files: |
Contributor
There was a problem hiding this comment.
This seems contradictory to the instruction above not to review these PRs — consider combining these instructions?
- Conditions all must be true, not just any one of them - Make it clearer that no files should be reviewed, except for the two listed ones
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Copilot instructions for handling release PRs to ensure proper review coverage. It establishes clear guidelines for identifying release PRs and specifies which files should be reviewed during the release process.
Key changes:
- Adds a "Generated code" section header to organize existing content
- Defines criteria for identifying release PRs using title, branch, and target patterns
- Specifies that only
CHANGELOG.mdandpackage.jsonshould be reviewed in release PRs
Comments suppressed due to low confidence (1)
.github/copilot-instructions.md:7
- Grammar inconsistency: 'start with two underscores' should be 'that start with two underscores' for consistency with the first usage in the sentence.
GitHub Actions workflows in the `.github/workflows` directory whose filenames start with two underscores (e.g. `__all-platform-bundle.yml`) are automatically generated using the `pr-checks/sync.sh` script from template files in the `pr-checks/checks` directory. Therefore, you do not need to review files in the `.github/workflows` directory that start with two underscores. However, you should review changes to the `pr-checks` directory as well as workflows in the `.github/workflows` directory that do not start with underscores.
henrymercer
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote some notes for this and then let Copilot edit them.
Risk assessment
For internal use only. Please select the risk level of this change:
Merge / deployment checklist